Calculating days between two dates in C

I think the idea is not to change things unnecessarily. If you have a function that does X, it shouldn't do Y if Y doesn't serve any practical purpose towards X, especially changing global values.

But it's not a global value. It's an argument to the function, passed by value, so the function can do whatever it pleases with it.