GMST Class Testing

Good luck figuring out variable names:

 get_combo_damage_param

Code:

int __cdecl get_combo_damage_param(int a1, int (*a2)(), signed int a3)
{
  int v3; // ebx@2
  int v4; // edi@2
  int v5; // esi@2
  signed __int16 v6; // bx@2
  int v7; // eax@2
  int v8; // eax@3
  int v9; // eax@4
  signed int v10; // eax@6
  int v11; // eax@6
  int (*v12)(); // eax@8
  int v13; // eax@12
  int v15; // eax@14
  int v16; // [sp-4h] [bp-18h]@4
  int v17; // [sp+Ch] [bp-8h]@2
  int v18; // [sp+10h] [bp-4h]@2
  int v19; // [sp+1Ch] [bp+8h]@2
  __int32 v20; // [sp+1Ch] [bp+8h]@3

  if ( a3 < 1
    || (v5 = a1,
        v6 = _ZtlSecureFuse((const __int16 *const )(a1 + 33), *(_DWORD *)(a1 + 37)),
        LOWORD(v7) = _ZtlSecureFuse((const __int16 *const )(a1 + 33), *(_DWORD *)(a1 + 37)),
        v17 = 0,
        v18 = 0,
        v19 = v7,
        v3 = CSkillInfo__GetSkillLevel(v5, (char *)_L269840 + (v6 / 1000 != 1 ? 0xFF676981 : 0) + 1, &v17),
        v4 = CSkillInfo__GetSkillLevel(
               v5,
               (char *)loc_A98672 + ((signed __int16)v19 / 1000 != 1 ? 0xFF67908E : 0) + 3,
               &v18),
        !v3) )
    return 0;
  v8 = SKILLENTRY__GetLevelData(v3);
  v20 = _ZtlSecureFuse((const __int32 *const )(v8 + 700), *(_DWORD *)(v8 + 708));
  if ( v4 )
  {
    v9 = SKILLENTRY__GetLevelData(v4);
    v20 += _ZtlSecureFuse((const __int32 *const )(v9 + 700), *(_DWORD *)(v9 + 708));
    v16 = v4;
  }
  else
  {
    v16 = v3;
  }
  v11 = SKILLENTRY__GetLevelData(v16);
  v10 = _ZtlSecureFuse((const __int32 *const )(v11 + 352), *(_DWORD *)(v11 + 360));
  if ( a3 >= v10 )
    a3 = v10;
  v12 = a2;
  if ( a2 == (int (*)())1111005
    || a2 == (int (*)())1111003
    || a2 == (int (*)())((char *)_L269840 + 2)
    || a2 == loc_A98A5B )
  {
    a2 = 0;
    v13 = CSkillInfo__GetSkillLevel(v5, v12, &a2);
    if ( !v13 )
      return 0;
    v15 = SKILLENTRY__GetLevelData(v13);
    v20 += _ZtlSecureFuse((const __int32 *const )(v15 + 364), *(_DWORD *)(v15 + 372));
  }
  return a3 * v20 + 100;
}

This code does answer one of the questions but I don't know enough to answer the other.

viz:
Pseudocode version of this:

Code:

get_combo_damage(job, attack, orbs) {
  if (orbs < 1 |  level_of_combo = 0) return 0;
  v20 = get_combo_damage_per_orb;
  if (level_of_adv_combo > 0) {
    v20 += get_adv_combo_damage_per_orb;
    v16 = advcomboid;
  }
  else
    v16 = comboid;
  v10 = getmaxorbs(v16); // uses skill id to decide which one to look up
  if (orbs > v10)
    orbs = v10
  if (attack = 1111005 || attack = 1111003 || attack == something || attack == somethingelse) {
    v13 = getlevel(job, attack, &attack);
    if (v13 == 0)
      return 0;
    v20 += get_attack_damage_per_orb;
  }
  return orbs*v20 + 100;
}

Or, in simpler terms,

Code:

get combo's bonus per orb
get adv. combo's bonus per orb
get skill specific bonus per orb
multiply by number of orbs
return total + 100

I don't know what skills 1111005, 1111003, ((char *)_L269840 + 2, loc_A98A5B refer to, but they should all have a damage bonus in the data similar to how the orb bonus is listed.




Anyway, conclusion:
Advanced Combo does do 10% for every orb, for a total of 200% with 10 orbs.